fluencelabs/marine-rs-sdk-test
1
0
Fork 0
mirror of https://github.com/fluencelabs/marine-rs-sdk-test synced 2024-12-04 23:30:18 +00:00
Code Issues Projects Releases Wiki Activity
394fb9abe6
marine-rs-sdk-test/docs/developer-notes.md
Mike Voronov e6bf209783
Add developer notes re PR reviewing (#15) 
* add developer notes

* Update docs/developer-notes.md

Co-authored-by: Valery Antopol <valery.antopol@gmail.com>

Co-authored-by: Valery Antopol <valery.antopol@gmail.com>
2022-04-26 16:22:42 +03:00

484 B
Raw Blame History

In marine-rs-sdk-test we use the following conventions for PR reviewing:

  • Concept ACK - agree with the idea and overall concept, but haven't reviewed the code changes or tested them,
  • utACK (untested ACK) - reviewed and agree with the code changes but haven't actually tested them,
  • Tested ACK - reviewed the code changes and have verified the functionality or a bug fix,
  • NACK - disagree with the code changes/concept, should be accompanied by an explanation.