fluencelabs/marine-rs-sdk-test
1
0
Fork 0
mirror of https://github.com/fluencelabs/marine-rs-sdk-test synced 2024-12-03 14:50:19 +00:00
Code Issues Projects Releases Wiki Activity

Add developer notes re PR reviewing (#15)

Browse Source 
* add developer notes

* Update docs/developer-notes.md

Co-authored-by: Valery Antopol <valery.antopol@gmail.com>

Co-authored-by: Valery Antopol <valery.antopol@gmail.com>
This commit is contained in:
Mike Voronov 2022-04-26 16:22:42 +03:00 committed by GitHub
parent cc0d1bec7f
commit e6bf209783
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
docs/developer-notes.md Normal file
View File

@ -0,0 +1,5 @@
In marine-rs-sdk-test we use the following conventions for PR reviewing:
- **Concept ACK** - agree with the idea and overall concept, but haven't reviewed the code changes or tested them,
- **utACK (untested ACK)** - reviewed and agree with the code changes but haven't actually tested them,
- **Tested ACK** - reviewed the code changes and have verified the functionality or a bug fix,
- **NACK** - disagree with the code changes/concept, should be accompanied by an explanation.