fluencelabs/wasmer
1
0
Fork 0
mirror of https://github.com/fluencelabs/wasmer synced 2024-12-13 14:25:32 +00:00
Code Issues Projects Releases Wiki Activity

Merge #1020

Browse Source 
1020: Turn a few more assert!s that should never fire into debug_assert!s. r=nlewycky a=nlewycky

These are here to protect against errors when refactoring more than anything else.


Co-authored-by: Nick Lewycky <nick@wasmer.io>
This commit is contained in:
bors[bot] 2019-11-27 01:16:34 +00:00 committed by GitHub
commit dfc7163b71
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/llvm-backend/src/code.rs
View File

@ -1764,11 +1764,11 @@ impl FunctionCodeGenerator<CodegenError> for LLVMFunctionCodeGenerator {
let info = { let info = {
let mut info = i1.strip_pending() & i2.strip_pending(); let mut info = i1.strip_pending() & i2.strip_pending();
if i1.has_pending_f32_nan() { if i1.has_pending_f32_nan() {
assert!(i2.has_pending_f32_nan()); debug_assert!(i2.has_pending_f32_nan());
info |= ExtraInfo::pending_f32_nan(); info |= ExtraInfo::pending_f32_nan();
} }
if i1.has_pending_f64_nan() { if i1.has_pending_f64_nan() {
assert!(i2.has_pending_f64_nan()); debug_assert!(i2.has_pending_f64_nan());
info |= ExtraInfo::pending_f64_nan(); info |= ExtraInfo::pending_f64_nan();
} }
info info

4
lib/llvm-backend/src/state.rs
View File

@ -163,12 +163,12 @@ impl BitAnd for ExtraInfo {
type Output = Self; type Output = Self;
fn bitand(self, other: Self) -> Self { fn bitand(self, other: Self) -> Self {
// Pending canonicalizations are not safe to discard, or even reorder. // Pending canonicalizations are not safe to discard, or even reorder.
assert!( debug_assert!(
self.has_pending_f32_nan() == other.has_pending_f32_nan() self.has_pending_f32_nan() == other.has_pending_f32_nan()
|| self.is_arithmetic_f32() || self.is_arithmetic_f32()
|| other.is_arithmetic_f32() || other.is_arithmetic_f32()
); );
assert!( debug_assert!(
self.has_pending_f64_nan() == other.has_pending_f64_nan() self.has_pending_f64_nan() == other.has_pending_f64_nan()
|| self.is_arithmetic_f64() || self.is_arithmetic_f64()
|| other.is_arithmetic_f64() || other.is_arithmetic_f64()