Use repr(transparent) for single element structs (#187)

The ABI of aggregates such as single element structs is not required to
be the same as the single elements themselves. This is especially true
for f64 vs. #[repr(c)] struct F(f64); on Windows. Therefore the macro
has been tweaked so S1 uses repr(transparent) which is made for exactly
for this use case.

Closes #183
This commit is contained in:
Christopher Serr 2019-02-16 00:11:06 +01:00 committed by Mackenzie Clark
parent 2d2d708500
commit cb29261ec7

View File

@ -154,8 +154,8 @@ where
} }
macro_rules! impl_traits { macro_rules! impl_traits {
( $struct_name:ident, $( $x:ident ),* ) => { ( [$repr:ident] $struct_name:ident, $( $x:ident ),* ) => {
#[repr(C)] #[repr($repr)]
pub struct $struct_name <$( $x ),*> ( $( $x ),* ); pub struct $struct_name <$( $x ),*> ( $( $x ),* );
impl< $( $x: WasmExternType, )* > WasmTypeList for ( $( $x ),* ) { impl< $( $x: WasmExternType, )* > WasmTypeList for ( $( $x ),* ) {
@ -234,18 +234,18 @@ macro_rules! impl_traits {
}; };
} }
impl_traits!(S0,); impl_traits!([C] S0,);
impl_traits!(S1, A); impl_traits!([transparent] S1, A);
impl_traits!(S2, A, B); impl_traits!([C] S2, A, B);
impl_traits!(S3, A, B, C); impl_traits!([C] S3, A, B, C);
impl_traits!(S4, A, B, C, D); impl_traits!([C] S4, A, B, C, D);
impl_traits!(S5, A, B, C, D, E); impl_traits!([C] S5, A, B, C, D, E);
impl_traits!(S6, A, B, C, D, E, F); impl_traits!([C] S6, A, B, C, D, E, F);
impl_traits!(S7, A, B, C, D, E, F, G); impl_traits!([C] S7, A, B, C, D, E, F, G);
impl_traits!(S8, A, B, C, D, E, F, G, H); impl_traits!([C] S8, A, B, C, D, E, F, G, H);
impl_traits!(S9, A, B, C, D, E, F, G, H, I); impl_traits!([C] S9, A, B, C, D, E, F, G, H, I);
impl_traits!(S10, A, B, C, D, E, F, G, H, I, J); impl_traits!([C] S10, A, B, C, D, E, F, G, H, I, J);
impl_traits!(S11, A, B, C, D, E, F, G, H, I, J, K); impl_traits!([C] S11, A, B, C, D, E, F, G, H, I, J, K);
impl<'a, Args, Rets, Safety> IsExport for Func<'a, Args, Rets, Safety> impl<'a, Args, Rets, Safety> IsExport for Func<'a, Args, Rets, Safety>
where where