Merge #436

436: Add deny for unreachable patterns and unused unsafe r=syrusakbary a=bjfish



Co-authored-by: Brandon Fish <brandon.j.fish@gmail.com>

lib/clif-backend/src/lib.rs

@@ -1,4 +1,4 @@
-#![deny(unused_imports, unused_variables)]
+#![deny(unused_imports, unused_variables, unused_unsafe, unreachable_patterns)]
 
 mod cache;
 mod func_env;

lib/emscripten/src/lib.rs

@@ -1,4 +1,4 @@
-#![deny(unused_imports, unused_variables)]
+#![deny(unused_imports, unused_variables, unused_unsafe, unreachable_patterns)]
 
 #[macro_use]
 extern crate wasmer_runtime_core;

lib/llvm-backend/src/lib.rs

@@ -1,4 +1,4 @@
-#![deny(unused_imports, unused_variables)]
+#![deny(unused_imports, unused_variables, unused_unsafe, unreachable_patterns)]
 #![cfg_attr(nightly, feature(unwind_attributes))]
 
 mod backend;

lib/middleware-common/src/lib.rs

@@ -1,3 +1,3 @@
-#![deny(unused_imports, unused_variables)]
+#![deny(unused_imports, unused_variables, unused_unsafe, unreachable_patterns)]
 
 pub mod call_trace;

lib/runtime-abi/src/lib.rs

@@ -1,4 +1,4 @@
-#![deny(unused_imports, unused_variables)]
+#![deny(unused_imports, unused_variables, unused_unsafe, unreachable_patterns)]
 
 #[cfg(not(target_os = "windows"))]
 #[macro_use]

lib/runtime-c-api/src/lib.rs

@@ -1,4 +1,4 @@
-#![deny(unused_imports, unused_variables)]
+#![deny(unused_imports, unused_variables, unused_unsafe, unreachable_patterns)]
 
 extern crate wasmer_runtime;
 extern crate wasmer_runtime_core;

lib/runtime-core/src/codegen.rs

@@ -35,7 +35,6 @@ impl fmt::Debug for InternalEvent {
             InternalEvent::Breakpoint(_) => write!(f, "Breakpoint"),
             InternalEvent::SetInternal(_) => write!(f, "SetInternal"),
             InternalEvent::GetInternal(_) => write!(f, "GetInternal"),
-            _ => panic!("unknown event"),
         }
     }
 }

lib/runtime-core/src/lib.rs

@@ -1,4 +1,4 @@
-#![deny(unused_imports, unused_variables)]
+#![deny(unused_imports, unused_variables, unused_unsafe, unreachable_patterns)]
 #![cfg_attr(nightly, feature(unwind_attributes))]
 
 #[cfg(test)]

lib/runtime/src/lib.rs

@@ -1,4 +1,4 @@
-#![deny(unused_imports, unused_variables)]
+#![deny(unused_imports, unused_variables, unused_unsafe, unreachable_patterns)]
 
 //! Wasmer-runtime is a library that makes embedding WebAssembly
 //! in your application easy, efficient, and safe.

lib/singlepass-backend/src/codegen_x64.rs

@@ -212,10 +212,10 @@ impl RunnableModule for X64ExecutionContext {
             user_error: *mut Option<Box<dyn Any>>,
             num_params_plus_one: Option<NonNull<c_void>>,
         ) -> bool {
-            let rm: &Box<dyn RunnableModule> = &unsafe { &*(*ctx).module }.runnable_module;
+            let rm: &Box<dyn RunnableModule> = &(&*(*ctx).module).runnable_module;
-            let execution_context = unsafe {
+            let execution_context =
-                ::std::mem::transmute_copy::<&dyn RunnableModule, &X64ExecutionContext>(&&**rm)
+                ::std::mem::transmute_copy::<&dyn RunnableModule, &X64ExecutionContext>(&&**rm);
-            };
+
             let args = ::std::slice::from_raw_parts(
                 args,
                 num_params_plus_one.unwrap().as_ptr() as usize - 1,

lib/singlepass-backend/src/lib.rs

@@ -1,4 +1,4 @@
-#![deny(unused_imports, unused_variables)]
+#![deny(unused_imports, unused_variables, unused_unsafe, unreachable_patterns)]
 #![feature(proc_macro_hygiene)]
 
 #[cfg(not(any(

lib/wasi/src/lib.rs

@@ -1,4 +1,4 @@
-#![deny(unused_imports, unused_variables)]
+#![deny(unused_imports, unused_variables, unused_unsafe, unreachable_patterns)]
 
 #[macro_use]
 extern crate log;

lib/win-exception-handler/src/lib.rs

@@ -1,4 +1,4 @@
-#![deny(unused_imports, unused_variables)]
+#![deny(unused_imports, unused_variables, unused_unsafe, unreachable_patterns)]
 
 #[cfg(windows)]
 mod exception_handling;

src/bin/wasmer.rs

@@ -1,4 +1,4 @@
-#![deny(unused_imports, unused_variables)]
+#![deny(unused_imports, unused_variables, unused_unsafe, unreachable_patterns)]
 
 extern crate structopt;
 

src/lib.rs

@@ -1,4 +1,4 @@
-#![deny(unused_imports, unused_variables)]
+#![deny(unused_imports, unused_variables, unused_unsafe, unreachable_patterns)]
 
 #[macro_use]
 extern crate wasmer_runtime_core;