fluencelabs/wasmer
1
0
Fork 0
mirror of https://github.com/fluencelabs/wasmer synced 2024-12-14 14:45:40 +00:00
Code Issues Projects Releases Wiki Activity

fix(runtime-core) Fix a panic when generating globals.

Browse Source 
Fix https://github.com/wasmerio/wasmer/issues/979.

When we try to get a global that doesn't exist, a panic is
generated. This patch just skip that path, and let a proper error be
generated later.

With this patch, we get:

```sh
$ cargo run -- run panic_index_oob_all_backends.wasm
Error: ExportNotFound { name: "main" }
```

which is kind of the expected behavior in such situation.
This commit is contained in:
Ivan Enderlin 2019-11-21 10:51:04 +01:00
parent 8efa8e299c
commit a9e446b5cd
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/runtime-core/src/backing.rs
View File

@ -450,6 +450,11 @@ impl LocalBacking {
let value = match &global_init.init { let value = match &global_init.init {
Initializer::Const(value) => value.clone(), Initializer::Const(value) => value.clone(),
Initializer::GetGlobal(import_global_index) => { Initializer::GetGlobal(import_global_index) => {
// Skip if the global hasn't been initialized properly.
if imports.globals.len() <= import_global_index.index() {
continue;
}
imports.globals[*import_global_index].get() imports.globals[*import_global_index].get()
} }
}; };