Fix some other files too

This commit is contained in:
Jordan Danford 2019-09-30 22:50:04 -07:00
parent 5a92e6b450
commit 9be72e6808
9 changed files with 28 additions and 31 deletions

View File

@ -15,9 +15,9 @@ assignees: ''
A clear and concise description of what the bug is. A clear and concise description of what the bug is.
Copy and paste the result of executing the following in your shell, so we can know the version of wasmer, Rust (if available) and architecture of your environment. Copy and paste the result of executing the following in your shell, so we can know the version of wasmer, Rust (if available) and architecture of your environment.
--> -->
```bash ```sh
echo "`wasmer -V` | `rustc -V` | `uname -m`" echo "`wasmer -V` | `rustc -V` | `uname -m`"
``` ```
@ -33,7 +33,7 @@ For example,
4. See error 4. See error
If applicable, add a link to a test case (as a zip file or link to a repository we can clone). If applicable, add a link to a test case (as a zip file or link to a repository we can clone).
--> -->
### Expected behavior ### Expected behavior
<!-- A clear and concise description of what you expected to happen. --> <!-- A clear and concise description of what you expected to happen. -->

View File

@ -3,12 +3,15 @@
Thank you for your interest in contributing to Wasmer. This document outlines some recommendations on how to contribute. Thank you for your interest in contributing to Wasmer. This document outlines some recommendations on how to contribute.
## Issues & Feature Requests ## Issues & Feature Requests
Please use the issue template and provide a failing example if possible to help us recreate the issue. Please use the issue template and provide a failing example if possible to help us recreate the issue.
## Pull Requests ## Pull Requests
For large changes, please try reaching the Wasmer using Github Issues or Spectrum Chat to ensure we can accept the change once it is ready.
For large changes, please try reaching communicating with the Wasmer maintainers via GitHub Issues or Spectrum Chat to ensure we can accept the change once it is ready.
We recommend trying the following commands before sending a pull request to ensure code quality: We recommend trying the following commands before sending a pull request to ensure code quality:
- `cargo fmt --all` Ensures all code is correctly formatted. - `cargo fmt --all` Ensures all code is correctly formatted.
- Run `cargo test` in the crates that you are modifying. - Run `cargo test` in the crates that you are modifying.
- Run `cargo build --all` (nightly) or `cargo build --all --exclude wasmer-singlepass-backend` - Run `cargo build --all` (nightly) or `cargo build --all --exclude wasmer-singlepass-backend`
@ -17,17 +20,14 @@ A comprehensive CI test suite will be run by a Wasmer team member after the PR h
### Common Build Issues ### Common Build Issues
**LLVM Dependency** #### LLVM Dependency
The LLVM backend requires LLVM to be installed to compile. `Didn't find usable system-wide LLVM`
So, you may run into the following error: Building Wasmer with the LLVM backend requires LLVM to be installed
```
Didn't find usable system-wide LLVM.
No suitable version of LLVM was found system-wide or pointed
```
**Singlepass Nightly Only** #### Singlepass Nightly Only
The singlepass crate depends on nightly so you may need to add the `+nightly` cargo flag to compile this crate.
`error[E0554]: #![feature] may not be used on the stable release channel` `error[E0554]: #![feature] may not be used on the stable release channel`
Building Wasmer with the singlepass backend requires the nightly version of Rust

View File

@ -161,7 +161,7 @@ release:
# Only one backend (cranelift) # Only one backend (cranelift)
release-clif: release-clif:
# If you are in OS-X, you will need mingw-w64 for cross compiling to windows # If you are on macOS, you will need mingw-w64 for cross compiling to Windows
# brew install mingw-w64 # brew install mingw-w64
cargo build --release cargo build --release

View File

@ -12,7 +12,6 @@
| SIMD | ⬜ | ⬜ | ✅ | | SIMD | ⬜ | ⬜ | ✅ |
| WASI | ✅ | ✅ | ✅ | | WASI | ✅ | ✅ | ✅ |
## Language integration ## Language integration
TODO: define a set of features that are relevant and mark them here TODO: define a set of features that are relevant and mark them here

View File

@ -1,8 +1,8 @@
#!/bin/sh #!/bin/sh
# This install script is intended to download and install the latest available # This install script is intended to download and install the latest available
# release of the wasmer. # release of Wasmer.
# Installer script inspired from: # Installer script inspired by:
# 1) https://raw.githubusercontent.com/golang/dep/master/install.sh # 1) https://raw.githubusercontent.com/golang/dep/master/install.sh
# 2) https://sh.rustup.rs # 2) https://sh.rustup.rs
# 3) https://yarnpkg.com/install.sh # 3) https://yarnpkg.com/install.sh
@ -22,7 +22,6 @@
set -e set -e
reset="\033[0m" reset="\033[0m"
red="\033[31m" red="\033[31m"
green="\033[32m" green="\033[32m"
@ -257,10 +256,10 @@ wasmer_install() {
printf "${reset}Installing Wasmer and WAPM!$reset\n" printf "${reset}Installing Wasmer and WAPM!$reset\n"
if [ "$WASMER_INSTALL_LOG" = "$WASMER_VERBOSE" ]; then if [ "$WASMER_INSTALL_LOG" = "$WASMER_VERBOSE" ]; then
printf " printf "
${magenta1} ww ${magenta1} ww
${magenta1} wwwww ${magenta1} wwwww
${magenta1} ww wwwwww w ${magenta1} ww wwwwww w
${magenta1} wwwww wwwwwwwww ${magenta1} wwwww wwwwwwwww
${magenta1}ww wwwwww w wwwwwww ${magenta1}ww wwwwww w wwwwwww
${magenta1}wwwww wwwwwwwwww wwwww ${magenta1}wwwww wwwwwwwwww wwwww
${magenta1}wwwwww w wwwwwww wwwww ${magenta1}wwwwww w wwwwwww wwwww
@ -269,10 +268,10 @@ ${magenta1}wwwwwwwwwwwwwww wwwww wwwww
${magenta1}wwwwwwwwwwwwwww wwwww wwwww ${magenta1}wwwwwwwwwwwwwww wwwww wwwww
${magenta1}wwwwwwwwwwwwwww wwwww wwwww ${magenta1}wwwwwwwwwwwwwww wwwww wwwww
${magenta1}wwwwwwwwwwwwwww wwwww wwww ${magenta1}wwwwwwwwwwwwwww wwwww wwww
${magenta1}wwwwwwwwwwwwwww wwwww ${magenta1}wwwwwwwwwwwwwww wwwww
${magenta1} wwwwwwwwwwww wwww ${magenta1} wwwwwwwwwwww wwww
${magenta1} wwwwwwww ${magenta1} wwwwwwww
${magenta1} wwww ${magenta1} wwww
${reset} ${reset}
" "
fi fi

View File

@ -1,9 +1,8 @@
# `cowsay` integration test # `cowsay` integration test
This starts Wasmer with the Cowsay WASI Wasm file. The test makes assertions on This starts Wasmer with the Cowsay WASI Wasm file. The test makes assertions on
the output of Wasmer. Run test with: the output of Wasmer. Run test with:
```bash ```sh
./integration_tests/cowsay/test.sh ./integration_tests/cowsay/test.sh
``` ```

View File

@ -36,7 +36,7 @@ This crate represents the Cranelift backend integration for Wasmer.
If you are using the `wasmer` CLI, you can specify the backend with: If you are using the `wasmer` CLI, you can specify the backend with:
```bash ```sh
wasmer run program.wasm --backend=cranelift wasmer run program.wasm --backend=cranelift
``` ```

View File

@ -36,7 +36,7 @@ This crate represents the LLVM backend integration for Wasmer.
If you are using the `wasmer` CLI, you can specify the backend with: If you are using the `wasmer` CLI, you can specify the backend with:
```bash ```sh
wasmer run program.wasm --backend=llvm wasmer run program.wasm --backend=llvm
``` ```

View File

@ -37,7 +37,7 @@ This crate represents the Singlepass backend integration for Wasmer.
If you are using the `wasmer` CLI, you can specify the backend with: If you are using the `wasmer` CLI, you can specify the backend with:
```bash ```sh
wasmer run program.wasm --backend=singlepass wasmer run program.wasm --backend=singlepass
``` ```