Merge #430

430: Add some initial deny for unused_imports and unused_variables r=bjfish a=bjfish



Co-authored-by: Brandon Fish <brandon.j.fish@gmail.com>

lib/clif-backend/src/lib.rs

@@ -1,3 +1,5 @@
+#![deny(unused_imports, unused_variables)]
+
 mod cache;
 mod func_env;
 mod libcalls;

lib/emscripten/src/lib.rs

@@ -1,3 +1,5 @@
+#![deny(unused_imports, unused_variables)]
+
 #[macro_use]
 extern crate wasmer_runtime_core;
 

lib/emscripten/src/syscalls/unix.rs

@@ -1,4 +1,6 @@
 use crate::varargs::VarArgs;
+#[cfg(target_os = "macos")]
+use libc::size_t;
 /// NOTE: TODO: These syscalls only support wasm_32 for now because they assume offsets are u32
 /// Syscall list: https://www.cs.utexas.edu/~bismith/test/syscalls/syscalls32.html
 use libc::{
@@ -53,7 +55,6 @@ use libc::{
     sendto,
     setpgid,
     setsockopt,
-    size_t,
     sockaddr,
     socket,
     socklen_t,

lib/llvm-backend/src/lib.rs

@@ -1,3 +1,4 @@
+#![deny(unused_imports, unused_variables)]
 #![cfg_attr(nightly, feature(unwind_attributes))]
 
 mod backend;

lib/llvm-backend/src/platform/unix.rs

@@ -34,7 +34,7 @@ pub unsafe fn visit_fde(addr: *mut u8, size: usize, visitor: extern "C" fn(*mut
 }
 
 #[cfg(not(target_os = "macos"))]
-pub unsafe fn visit_fde(addr: *mut u8, size: usize, visitor: extern "C" fn(*mut u8)) {
+pub unsafe fn visit_fde(addr: *mut u8, _size: usize, visitor: extern "C" fn(*mut u8)) {
     visitor(addr);
 }
 

lib/middleware-common/src/call_trace.rs

@@ -10,7 +10,7 @@ impl FunctionMiddleware for CallTrace {
     fn feed_event<'a, 'b: 'a>(
         &mut self,
         op: Event<'a, 'b>,
-        module_info: &ModuleInfo,
+        _module_info: &ModuleInfo,
         sink: &mut EventSink<'a, 'b>,
     ) -> Result<(), Self::Error> {
         match op {

lib/middleware-common/src/lib.rs

@@ -1 +1,3 @@
+#![deny(unused_imports, unused_variables)]
+
 pub mod call_trace;

lib/runtime-abi/src/lib.rs

@@ -1,3 +1,5 @@
+#![deny(unused_imports, unused_variables)]
+
 #[cfg(not(target_os = "windows"))]
 #[macro_use]
 extern crate failure;

lib/runtime-c-api/src/lib.rs

@@ -1,3 +1,5 @@
+#![deny(unused_imports, unused_variables)]
+
 extern crate wasmer_runtime;
 extern crate wasmer_runtime_core;
 

lib/runtime-core/src/codegen.rs

@@ -1,6 +1,6 @@
 use crate::{
     backend::RunnableModule,
-    backend::{sys::Memory, Backend, CacheGen, Compiler, CompilerConfig, Token},
+    backend::{Backend, CacheGen, Compiler, CompilerConfig, Token},
     cache::{Artifact, Error as CacheError},
     error::{CompileError, CompileResult},
     module::{ModuleInfo, ModuleInner},

lib/runtime-core/src/lib.rs

@@ -1,3 +1,4 @@
+#![deny(unused_imports, unused_variables)]
 #![cfg_attr(nightly, feature(unwind_attributes))]
 
 #[cfg(test)]

lib/runtime/src/lib.rs

@@ -1,3 +1,5 @@
+#![deny(unused_imports, unused_variables)]
+
 //! Wasmer-runtime is a library that makes embedding WebAssembly
 //! in your application easy, efficient, and safe.
 //!

lib/singlepass-backend/src/codegen_x64.rs

@@ -478,7 +478,7 @@ impl ModuleCodeGenerator<X64FunctionCode, X64ExecutionContext, CodegenError>
         Ok(())
     }
 
-    unsafe fn from_cache(artifact: Artifact, _: Token) -> Result<ModuleInner, CacheError> {
+    unsafe fn from_cache(_artifact: Artifact, _: Token) -> Result<ModuleInner, CacheError> {
         Err(CacheError::Unknown(
             "the singlepass compiler API doesn't support caching yet".to_string(),
         ))
@@ -1409,7 +1409,7 @@ impl FunctionCodeGenerator<CodegenError> for X64FunctionCode {
         Ok(())
     }
 
-    fn begin_body(&mut self, module_info: &ModuleInfo) -> Result<(), CodegenError> {
+    fn begin_body(&mut self, _module_info: &ModuleInfo) -> Result<(), CodegenError> {
         let a = self.assembler.as_mut().unwrap();
         a.emit_push(Size::S64, Location::GPR(GPR::RBP));
         a.emit_mov(Size::S64, Location::GPR(GPR::RSP), Location::GPR(GPR::RBP));

lib/singlepass-backend/src/lib.rs

@@ -1,3 +1,4 @@
+#![deny(unused_imports, unused_variables)]
 #![feature(proc_macro_hygiene)]
 
 #[cfg(not(any(

lib/wasi/src/lib.rs

@@ -1,3 +1,5 @@
+#![deny(unused_imports, unused_variables)]
+
 #[macro_use]
 extern crate log;
 

lib/win-exception-handler/src/exception_handling.rs

@@ -1,4 +1,3 @@
-use std::ffi::c_void;
 use std::ptr::NonNull;
 use wasmer_runtime_core::vm::{Ctx, Func};
 

lib/win-exception-handler/src/lib.rs

@@ -1,3 +1,5 @@
+#![deny(unused_imports, unused_variables)]
+
 #[cfg(windows)]
 mod exception_handling;
 

src/bin/wasmer.rs

@@ -1,3 +1,5 @@
+#![deny(unused_imports, unused_variables)]
+
 extern crate structopt;
 
 use std::env;

src/lib.rs

@@ -1,3 +1,5 @@
+#![deny(unused_imports, unused_variables)]
+
 #[macro_use]
 extern crate wasmer_runtime_core;
 // extern crate wasmer_emscripten;