Fix review comments

lib/runtime/src/cache.rs

@@ -4,93 +4,6 @@ use std::{fs::create_dir_all, io, path::PathBuf};
 pub use wasmer_runtime_core::cache::{Cache, WasmHash};
 use wasmer_runtime_core::cache::{Error as CacheError, SerializedCache};
 
-// ///
-// /// # Drawbacks:
-// ///
-// /// Due to internal shortcomings, you cannot convert
-// /// a module into a `Cache`. This means that compiling
-// /// into a `Cache` and then converting into a module
-// /// has more overhead than directly compiling
-// /// into a [`Module`].
-// ///
-// /// [`Module`]: struct.Module.html
-// pub struct Cache(pub(crate) CoreCache);
-
-// impl Cache {
-//     /// Load a `Cache` from the file specified by `path`.
-//     ///
-//     /// # Usage:
-//     ///
-//     /// ```
-//     /// use wasmer_runtime::Cache;
-//     /// # use wasmer_runtime::error::CacheError;
-//     ///
-//     /// # fn load_cache() -> Result<(), CacheError> {
-//     /// let cache = Cache::load("some_file.cache")?;
-//     /// # Ok(())
-//     /// # }
-//     /// ```
-//     pub fn load<P: AsRef<Path>>(path: P) -> Result<Self, Error> {
-//         CoreCache::open(path).map(|core_cache| Cache(core_cache))
-//     }
-
-//     /// Convert a `Cache` into a [`Module`].
-//     ///
-//     /// [`Module`]: struct.Module.html
-//     ///
-//     /// # Usage:
-//     ///
-//     /// ```
-//     /// use wasmer_runtime::Cache;
-//     ///
-//     /// # use wasmer_runtime::error::CacheError;
-//     /// # fn cache2module(cache: Cache) -> Result<(), CacheError> {
-//     /// let module = unsafe { cache.into_module()? };
-//     /// # Ok(())
-//     /// # }
-//     /// ```
-//     ///
-//     /// # Notes:
-//     ///
-//     /// This method is unsafe because the runtime cannot confirm
-//     /// that this cache was not tampered with or corrupted.
-//     pub unsafe fn into_module(self) -> Result<Module, Error> {
-//         let default_compiler = super::default_compiler();
-
-//         wasmer_runtime_core::load_cache_with(self.0, default_compiler)
-//     }
-
-//     /// Compare the Sha256 hash of the wasm this cache was build
-//     /// from with some other WebAssembly.
-//     ///
-//     /// The main use-case for this is invalidating old caches.
-//     pub fn compare_wasm(&self, wasm: &[u8]) -> bool {
-//         let param_wasm_hash = hash_data(wasm);
-//         self.0.wasm_hash() as &[u8] == &param_wasm_hash as &[u8]
-//     }
-
-//     /// Store this cache in a file.
-//     ///
-//     /// # Notes:
-//     ///
-//     /// If a file exists at the specified path, it will be overwritten.
-//     ///
-//     /// # Usage:
-//     ///
-//     /// ```
-//     /// use wasmer_runtime::Cache;
-//     ///
-//     /// # use wasmer_runtime::error::CacheError;
-//     /// # fn store_cache(cache: Cache) -> Result<(), CacheError> {
-//     /// cache.store("some_file.cache")?;
-//     /// # Ok(())
-//     /// # }
-//     /// ```
-//     pub fn store<P: AsRef<Path>>(&self, path: P) -> Result<(), Error> {
-//         self.0.store(path)
-//     }
-// }
-
 /// Representation of a directory that contains compiled wasm artifacts.
 ///
 /// The `FileSystemCache` type implements the [`Cache`] trait, which allows it to be used

lib/runtime/src/lib.rs

@@ -152,30 +152,6 @@ pub fn instantiate(wasm: &[u8], import_object: &ImportObject) -> error::Result<I
     module.instantiate(import_object)
 }
 
-// /// Compile wasm into a [`Cache`] that can be stored to a file or
-// /// converted into [`Module`].
-// ///
-// /// [`Cache`]: struct.Cache.html
-// /// [`Module`]: struct.Module.html
-// ///
-// /// # Usage:
-// ///
-// /// ```
-// /// # use wasmer_runtime::error::CompileResult;
-// /// use wasmer_runtime::compile_cache;
-// ///
-// /// # fn make_cache(wasm: &[u8]) -> CompileResult<()> {
-// /// let cache = compile_cache(wasm)?;
-// /// # Ok(())
-// /// # }
-// /// ```
-// pub fn compile_cache(wasm: &[u8]) -> error::CompileResult<Cache> {
-//     let default_compiler = default_compiler();
-
-//     wasmer_runtime_core::compile_to_cache_with(wasm, default_compiler)
-//         .map(|core_cache| Cache(core_cache))
-// }
-
 fn default_compiler() -> &'static dyn Compiler {
     use lazy_static::lazy_static;
     use wasmer_clif_backend::CraneliftCompiler;