feat(compiler): Always generate last argument of fold [LNG-265] (#947)

* Always generate last in fold

* Fix unit tests

* Add methods
This commit is contained in:
InversionSpaces 2023-10-30 10:58:51 +01:00 committed by GitHub
parent 634b1c17b6
commit 78ee753c7b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
19 changed files with 254 additions and 177 deletions

View File

@ -93,7 +93,7 @@ object Air {
iterable: DataView, iterable: DataView,
label: String, label: String,
instruction: Air, instruction: Air,
lastNextInstruction: Option[Air] lastNextInstruction: Air
) extends Air(Keyword.Fold) ) extends Air(Keyword.Fold)
case class Match(left: DataView, right: DataView, instruction: Air) extends Air(Keyword.Match) case class Match(left: DataView, right: DataView, instruction: Air) extends Air(Keyword.Match)
@ -137,7 +137,7 @@ object Air {
case Air.Next(label) s" $label" case Air.Next(label) s" $label"
case Air.New(item, inst) s" ${item.show}\n${showNext(inst)}$space" case Air.New(item, inst) s" ${item.show}\n${showNext(inst)}$space"
case Air.Fold(iter, label, inst, lastInst) case Air.Fold(iter, label, inst, lastInst)
val l = lastInst.map(a => show(depth + 1, a)).getOrElse("") val l = show(depth + 1, lastInst)
s" ${iter.show} $label\n${showNext(inst)}$l$space" s" ${iter.show} $label\n${showNext(inst)}$l$space"
case Air.Match(left, right, inst) case Air.Match(left, right, inst)
s" ${left.show} ${right.show}\n${showNext(inst)}$space" s" ${left.show} ${right.show}\n${showNext(inst)}$space"

View File

@ -94,9 +94,9 @@ object AirGen extends Logging {
) )
case FoldRes(item, iterable, mode) => case FoldRes(item, iterable, mode) =>
val m = mode.map { val m = mode match {
case ForModel.Mode.Null => NullGen case FoldRes.Mode.Null => NullGen
case ForModel.Mode.Never => NeverGen case FoldRes.Mode.Never => NeverGen
} }
Eval later ForGen(valueToData(iterable), item, opsToSingle(ops), m) Eval later ForGen(valueToData(iterable), item, opsToSingle(ops), m)
case RestrictionRes(item, itemType) => case RestrictionRes(item, itemType) =>
@ -202,9 +202,8 @@ case class MatchMismatchGen(
else Air.Mismatch(left, right, body.generate) else Air.Mismatch(left, right, body.generate)
} }
case class ForGen(iterable: DataView, item: String, body: AirGen, mode: Option[AirGen]) case class ForGen(iterable: DataView, item: String, body: AirGen, mode: AirGen) extends AirGen {
extends AirGen { override def generate: Air = Air.Fold(iterable, item, body.generate, mode.generate)
override def generate: Air = Air.Fold(iterable, item, body.generate, mode.map(_.generate))
} }
case class NewGen(name: String, body: AirGen) extends AirGen { case class NewGen(name: String, body: AirGen) extends AirGen {

View File

@ -169,34 +169,36 @@ class AquaCompilerSpec extends AnyFlatSpec with Matchers with Inside {
RestrictionRes(results.name, resultsType).wrap( RestrictionRes(results.name, resultsType).wrap(
SeqRes.wrap( SeqRes.wrap(
ParRes.wrap( ParRes.wrap(
FoldRes(peer.name, peers, ForModel.Mode.Never.some).wrap( FoldRes
ParRes.wrap( .lastNever(peer.name, peers)
XorRes.wrap( .wrap(
// better if first relay will be outside `for` ParRes.wrap(
SeqRes.wrap( XorRes.wrap(
through(ValueModel.fromRaw(relay)), // better if first relay will be outside `for`
CallServiceRes( SeqRes.wrap(
LiteralModel.fromRaw(LiteralRaw.quote("op")), through(ValueModel.fromRaw(relay)),
"identity", CallServiceRes(
CallRes( LiteralModel.fromRaw(LiteralRaw.quote("op")),
LiteralModel.fromRaw(LiteralRaw.quote("hahahahah")) :: Nil, "identity",
Some(CallModel.Export(retVar.name, retVar.`type`)) CallRes(
), LiteralModel.fromRaw(LiteralRaw.quote("hahahahah")) :: Nil,
peer Some(CallModel.Export(retVar.name, retVar.`type`))
).leaf, ),
ApRes(retVar, CallModel.Export(results.name, results.`type`)).leaf, peer
through(ValueModel.fromRaw(relay)), ).leaf,
through(initPeer) ApRes(retVar, CallModel.Export(results.name, results.`type`)).leaf,
through(ValueModel.fromRaw(relay)),
through(initPeer)
),
SeqRes.wrap(
through(ValueModel.fromRaw(relay)),
through(initPeer),
failErrorRes
)
), ),
SeqRes.wrap( NextRes(peer.name).leaf
through(ValueModel.fromRaw(relay)), )
through(initPeer),
failErrorRes
)
),
NextRes(peer.name).leaf
) )
)
), ),
join(results, LiteralModel.number(3)), // Compiler optimized addition join(results, LiteralModel.number(3)), // Compiler optimized addition
CanonRes( CanonRes(

View File

@ -227,12 +227,12 @@ object TagInliner extends Logging {
) )
} }
_ <- Exports[S].resolved(item, VarModel(n, elementType)) _ <- Exports[S].resolved(item, VarModel(n, elementType))
m = mode.map { modeModel = mode match {
case ForTag.Mode.Wait => ForModel.Mode.Never case ForTag.Mode.Blocking => ForModel.Mode.Never
case ForTag.Mode.Pass => ForModel.Mode.Null case ForTag.Mode.NonBlocking => ForModel.Mode.Null
} }
} yield TagInlined.Single( } yield TagInlined.Single(
model = ForModel(n, v, m), model = ForModel(n, v, modeModel),
prefix = p prefix = p
) )

View File

@ -56,7 +56,7 @@ object StreamGateInliner extends Logging {
val resultCanon = VarModel(canonName, CanonStreamType(streamType.element)) val resultCanon = VarModel(canonName, CanonStreamType(streamType.element))
RestrictionModel(varSTest.name, streamType).wrap( RestrictionModel(varSTest.name, streamType).wrap(
ForModel(iter.name, VarModel(streamName, streamType), ForModel.Mode.Never.some).wrap( ForModel(iter.name, VarModel(streamName, streamType), ForModel.Mode.Never).wrap(
PushToStreamModel( PushToStreamModel(
iter, iter,
CallModel.Export(varSTest.name, varSTest.`type`) CallModel.Export(varSTest.name, varSTest.`type`)

View File

@ -2064,8 +2064,12 @@ class ArrowInlinerSpec extends AnyFlatSpec with Matchers with Inside {
.leaf .leaf
) )
val foldOp = val foldOp = ForTag
ForTag(iVar.name, array, ForTag.Mode.Wait.some).wrap(inFold, NextTag(iVar.name).leaf) .blocking(iVar.name, array)
.wrap(
inFold,
NextTag(iVar.name).leaf
)
val model: OpModel.Tree = ArrowInliner val model: OpModel.Tree = ArrowInliner
.callArrow[InliningState]( .callArrow[InliningState](
@ -2091,14 +2095,16 @@ class ArrowInlinerSpec extends AnyFlatSpec with Matchers with Inside {
._2 ._2
model.equalsOrShowDiff( model.equalsOrShowDiff(
ForModel(iVar0.name, ValueModel.fromRaw(array), ForModel.Mode.Never.some).wrap( ForModel
CallServiceModel( .neverMode(iVar0.name, ValueModel.fromRaw(array))
LiteralModel.fromRaw(serviceId), .wrap(
fnName, CallServiceModel(
CallModel(LiteralModel.number(1) :: Nil, Nil) LiteralModel.fromRaw(serviceId),
).leaf, fnName,
NextModel(iVar0.name).leaf CallModel(LiteralModel.number(1) :: Nil, Nil)
) ).leaf,
NextModel(iVar0.name).leaf
)
) should be(true) ) should be(true)
} }

View File

@ -168,8 +168,7 @@ case class RestrictionTag(name: String, `type`: DataType) extends SeqGroupTag {
copy(name = map.getOrElse(name, name)) copy(name = map.getOrElse(name, name))
} }
case class ForTag(item: String, iterable: ValueRaw, mode: Option[ForTag.Mode] = None) case class ForTag(item: String, iterable: ValueRaw, mode: ForTag.Mode) extends SeqGroupTag {
extends SeqGroupTag {
override def restrictsVarNames: Set[String] = Set(item) override def restrictsVarNames: Set[String] = Set(item)
@ -185,9 +184,15 @@ case class ForTag(item: String, iterable: ValueRaw, mode: Option[ForTag.Mode] =
object ForTag { object ForTag {
enum Mode { enum Mode {
case Wait case Blocking
case Pass case NonBlocking
} }
def blocking(item: String, iterable: ValueRaw): ForTag =
ForTag(item, iterable, Mode.Blocking)
def nonBlocking(item: String, iterable: ValueRaw): ForTag =
ForTag(item, iterable, Mode.NonBlocking)
} }
case class CallArrowRawTag( case class CallArrowRawTag(

View File

@ -46,7 +46,13 @@ object MakeRes {
case SeqModel | _: OnModel | _: ApplyTopologyModel => SeqRes.leaf case SeqModel | _: OnModel | _: ApplyTopologyModel => SeqRes.leaf
case MatchMismatchModel(a, b, s) => case MatchMismatchModel(a, b, s) =>
MatchMismatchRes(a, b, s).leaf MatchMismatchRes(a, b, s).leaf
case ForModel(item, iter, mode) if !isNillLiteral(iter) => FoldRes(item, iter, mode).leaf case ForModel(item, iter, mode) if !isNillLiteral(iter) =>
val modeRes = mode match {
case ForModel.Mode.Null => FoldRes.Mode.Null
case ForModel.Mode.Never => FoldRes.Mode.Never
}
FoldRes(item, iter, modeRes).leaf
case RestrictionModel(item, itemType) => RestrictionRes(item, itemType).leaf case RestrictionModel(item, itemType) => RestrictionRes(item, itemType).leaf
case DetachModel => ParRes.leaf case DetachModel => ParRes.leaf
case ParModel => ParRes.leaf case ParModel => ParRes.leaf

View File

@ -32,9 +32,18 @@ case class MatchMismatchRes(left: ValueModel, right: ValueModel, shouldMatch: Bo
override def toString: String = s"(${if (shouldMatch) "match" else "mismatch"} $left $right)" override def toString: String = s"(${if (shouldMatch) "match" else "mismatch"} $left $right)"
} }
case class FoldRes(item: String, iterable: ValueModel, mode: Option[ForModel.Mode] = None) case class FoldRes(item: String, iterable: ValueModel, mode: FoldRes.Mode) extends ResolvedOp {
extends ResolvedOp { override def toString: String = s"(fold $iterable $item ${mode.toString.toLowerCase()}"
override def toString: String = s"(fold $iterable $item ${mode.map(_.toString).getOrElse("")}" }
object FoldRes {
enum Mode { case Null, Never }
def lastNull(item: String, iterable: ValueModel): FoldRes =
FoldRes(item, iterable, Mode.Null)
def lastNever(item: String, iterable: ValueModel): FoldRes =
FoldRes(item, iterable, Mode.Never)
} }
case class RestrictionRes(item: String, `type`: DataType) extends ResolvedOp { case class RestrictionRes(item: String, `type`: DataType) extends ResolvedOp {
@ -50,7 +59,8 @@ case class CallServiceRes(
override def toString: String = s"(call $peerId ($serviceId $funcName) $call)" override def toString: String = s"(call $peerId ($serviceId $funcName) $call)"
} }
case class ApStreamMapRes(key: ValueModel, value: ValueModel, exportTo: CallModel.Export) extends ResolvedOp { case class ApStreamMapRes(key: ValueModel, value: ValueModel, exportTo: CallModel.Export)
extends ResolvedOp {
override def toString: String = s"(ap ($key $value) $exportTo)" override def toString: String = s"(ap ($key $value) $exportTo)"
} }

View File

@ -18,7 +18,7 @@ object ResBuilder {
val arrayRes = VarModel(stream.name + "_gate", ArrayType(ScalarType.string)) val arrayRes = VarModel(stream.name + "_gate", ArrayType(ScalarType.string))
RestrictionRes(testVM.name, testStreamType).wrap( RestrictionRes(testVM.name, testStreamType).wrap(
FoldRes(iter.name, stream, ForModel.Mode.Never.some).wrap( FoldRes(iter.name, stream, FoldRes.Mode.Never).wrap(
ApRes(iter, CallModel.Export(testVM.name, testVM.`type`)).leaf, ApRes(iter, CallModel.Export(testVM.name, testVM.`type`)).leaf,
CanonRes(testVM, peer, CallModel.Export(canon.name, canon.`type`)).leaf, CanonRes(testVM, peer, CallModel.Export(canon.name, canon.`type`)).leaf,
XorRes.wrap( XorRes.wrap(

View File

@ -147,11 +147,11 @@ case class MatchMismatchModel(left: ValueModel, right: ValueModel, shouldMatch:
case class ForModel( case class ForModel(
item: String, item: String,
iterable: ValueModel, iterable: ValueModel,
mode: Option[ForModel.Mode] = Some(ForModel.Mode.Null) mode: ForModel.Mode = ForModel.Mode.Null
) extends SeqGroupModel { ) extends SeqGroupModel {
override def toString: String = override def toString: String =
s"for $item <- $iterable${mode.map(m => " " + m.toString).getOrElse("")}" s"for $item <- $iterable${mode.toString}"
override def restrictsVarNames: Set[String] = Set(item) override def restrictsVarNames: Set[String] = Set(item)
@ -165,6 +165,12 @@ object ForModel {
case Null case Null
case Never case Never
} }
def neverMode(item: String, iterable: ValueModel): ForModel =
ForModel(item, iterable, Mode.Never)
def nullMode(item: String, iterable: ValueModel): ForModel =
ForModel(item, iterable, Mode.Null)
} }
// TODO how is it used? remove, if it's not // TODO how is it used? remove, if it's not
@ -175,7 +181,12 @@ case class DeclareStreamModel(value: ValueModel) extends NoExecModel {
} }
// key must be only string or number // key must be only string or number
case class InsertKeyValueModel(key: ValueModel, value: ValueModel, assignTo: String, assignToType: StreamMapType) extends OpModel { case class InsertKeyValueModel(
key: ValueModel,
value: ValueModel,
assignTo: String,
assignToType: StreamMapType
) extends OpModel {
override def usesVarNames: Set[String] = value.usesVarNames override def usesVarNames: Set[String] = value.usesVarNames
override def exportsVarNames: Set[String] = Set(assignTo) override def exportsVarNames: Set[String] = Set(assignTo)

View File

@ -35,12 +35,14 @@ case class ArgsFromService(dataServiceId: ValueRaw) extends ArgsProvider {
Call(Nil, Call.Export(iter, ArrayType(t.element)) :: Nil) Call(Nil, Call.Export(iter, ArrayType(t.element)) :: Nil)
) )
.leaf, .leaf,
ForTag(item, VarRaw(iter, ArrayType(t.element))).wrap( ForTag
SeqTag.wrap( .nonBlocking(item, VarRaw(iter, ArrayType(t.element)))
PushToStreamTag(VarRaw(item, t.element), Call.Export(varName, t)).leaf, .wrap(
NextTag(item).leaf SeqTag.wrap(
PushToStreamTag(VarRaw(item, t.element), Call.Export(varName, t)).leaf,
NextTag(item).leaf
)
) )
)
) )
} }

View File

@ -377,7 +377,11 @@ object Topology extends Logging {
NextRes(itemName).leaf NextRes(itemName).leaf
) )
FoldRes(itemName, v).wrap(if (reversed) steps.reverse else steps) FoldRes
.lastNull(itemName, v)
.wrap(
if (reversed) steps.reverse else steps
)
case _ => case _ =>
MakeRes.hop(v) MakeRes.hop(v)
} }

View File

@ -124,7 +124,7 @@ object ModelBuilder {
failErrorModel failErrorModel
) )
def fold(item: String, iter: ValueRaw, mode: Option[ForModel.Mode], body: OpModel.Tree*) = { def fold(item: String, iter: ValueRaw, mode: ForModel.Mode, body: OpModel.Tree*) = {
val ops = SeqModel.wrap(body: _*) val ops = SeqModel.wrap(body: _*)
ForModel(item, ValueModel.fromRaw(iter), mode).wrap(ops, NextModel(item).leaf) ForModel(item, ValueModel.fromRaw(iter), mode).wrap(ops, NextModel(item).leaf)
} }
@ -132,7 +132,8 @@ object ModelBuilder {
def foldPar(item: String, iter: ValueRaw, body: OpModel.Tree*) = { def foldPar(item: String, iter: ValueRaw, body: OpModel.Tree*) = {
val ops = SeqModel.wrap(body: _*) val ops = SeqModel.wrap(body: _*)
DetachModel.wrap( DetachModel.wrap(
ForModel(item, ValueModel.fromRaw(iter), ForModel.Mode.Never.some) ForModel
.neverMode(item, ValueModel.fromRaw(iter))
.wrap(ParModel.wrap(ops, NextModel(item).leaf)) .wrap(ParModel.wrap(ops, NextModel(item).leaf))
) )
} }

View File

@ -1,7 +1,7 @@
package aqua.model.transform.topology package aqua.model.transform.topology
import aqua.model.transform.ModelBuilder import aqua.model.transform.ModelBuilder
import aqua.model.{CallModel, OnModel, SeqModel} import aqua.model.{CallModel, ForModel, OnModel, SeqModel}
import aqua.model.transform.cursor.ChainZipper import aqua.model.transform.cursor.ChainZipper
import aqua.raw.value.{LiteralRaw, ValueRaw, VarRaw} import aqua.raw.value.{LiteralRaw, ValueRaw, VarRaw}
import aqua.raw.ops.{Call, FuncOp, OnTag} import aqua.raw.ops.{Call, FuncOp, OnTag}
@ -137,7 +137,7 @@ class OpModelTreeCursorSpec extends AnyFlatSpec with Matchers {
fold( fold(
"item", "item",
VarRaw("iterable", ArrayType(ScalarType.string)), VarRaw("iterable", ArrayType(ScalarType.string)),
None, ForModel.Mode.Null,
OnModel( OnModel(
VarRaw("-in-fold-", ScalarType.string), VarRaw("-in-fold-", ScalarType.string),
Chain.one(VarRaw("-fold-relay-", ScalarType.string)) Chain.one(VarRaw("-fold-relay-", ScalarType.string))

View File

@ -463,7 +463,8 @@ class TopologySpec extends AnyFlatSpec with Matchers {
through(relay), through(relay),
callRes(0, otherPeer), callRes(0, otherPeer),
ParRes.wrap( ParRes.wrap(
FoldRes("i", valueArray, ForModel.Mode.Never.some) FoldRes
.lastNever("i", valueArray)
.wrap(ParRes.wrap(callRes(2, otherPeer2), NextRes("i").leaf)) .wrap(ParRes.wrap(callRes(2, otherPeer2), NextRes("i").leaf))
), ),
through(relay), through(relay),
@ -509,26 +510,28 @@ class TopologySpec extends AnyFlatSpec with Matchers {
val proc = Topology.resolve(init).value val proc = Topology.resolve(init).value
val foldRes = ParRes.wrap( val foldRes = ParRes.wrap(
FoldRes("i", valueArray, ForModel.Mode.Never.some).wrap( FoldRes
ParRes.wrap( .lastNever("i", valueArray)
// better if first relay will be outside `for` .wrap(
SeqRes.wrap( ParRes.wrap(
through(relay), // better if first relay will be outside `for`
XorRes.wrap( SeqRes.wrap(
SeqRes.wrap( through(relay),
callRes(2, iRelay, Some(CallModel.Export(streamRaw.name, streamRaw.`type`))), XorRes.wrap(
through(relay), SeqRes.wrap(
through(initPeer) callRes(2, iRelay, Some(CallModel.Export(streamRaw.name, streamRaw.`type`))),
), through(relay),
SeqRes.wrap( through(initPeer)
through(relay), ),
callRes(4, initPeer) SeqRes.wrap(
through(relay),
callRes(4, initPeer)
)
) )
) ),
), NextRes("i").leaf
NextRes("i").leaf )
) )
)
) )
val expected = SeqRes.wrap( val expected = SeqRes.wrap(
Chain( Chain(
@ -579,28 +582,30 @@ class TopologySpec extends AnyFlatSpec with Matchers {
val proc = Topology.resolve(init).value val proc = Topology.resolve(init).value
val fold = ParRes.wrap( val fold = ParRes.wrap(
FoldRes("i", valueArray, ForModel.Mode.Never.some).wrap( FoldRes
ParRes.wrap( .lastNever("i", valueArray)
// better if first relay will be outside `for` .wrap(
SeqRes.wrap( ParRes.wrap(
through(relay), // better if first relay will be outside `for`
XorRes.wrap( SeqRes.wrap(
through(relay),
XorRes.wrap( XorRes.wrap(
XorRes.wrap(
SeqRes.wrap(
callRes(2, iRelay, Some(CallModel.Export(streamRaw.name, streamRaw.`type`))),
through(relay),
through(initPeer)
)
),
SeqRes.wrap( SeqRes.wrap(
callRes(2, iRelay, Some(CallModel.Export(streamRaw.name, streamRaw.`type`))),
through(relay), through(relay),
through(initPeer) callRes(4, initPeer)
) )
),
SeqRes.wrap(
through(relay),
callRes(4, initPeer)
) )
) ),
), NextRes("i").leaf
NextRes("i").leaf )
) )
)
) )
val expected = SeqRes.wrap( val expected = SeqRes.wrap(
Chain( Chain(
@ -626,7 +631,7 @@ class TopologySpec extends AnyFlatSpec with Matchers {
fold( fold(
"i", "i",
valueArray, valueArray,
None, ForModel.Mode.Null,
OnModel(otherPeer2, Chain.one(otherRelay2)).wrap( OnModel(otherPeer2, Chain.one(otherRelay2)).wrap(
callModel(2) callModel(2)
) )
@ -643,10 +648,12 @@ class TopologySpec extends AnyFlatSpec with Matchers {
through(relay), through(relay),
callRes(1, otherPeer), callRes(1, otherPeer),
through(otherRelay2), through(otherRelay2),
FoldRes("i", valueArray).wrap( FoldRes
callRes(2, otherPeer2), .lastNull("i", valueArray)
NextRes("i").leaf .wrap(
), callRes(2, otherPeer2),
NextRes("i").leaf
),
through(otherRelay2), through(otherRelay2),
through(relay), through(relay),
callRes(3, initPeer) callRes(3, initPeer)
@ -662,7 +669,7 @@ class TopologySpec extends AnyFlatSpec with Matchers {
fold( fold(
"i", "i",
valueArray, valueArray,
None, ForModel.Mode.Null,
OnModel(i, Chain.one(otherRelay)).wrap( OnModel(i, Chain.one(otherRelay)).wrap(
callModel(1) callModel(1)
) )
@ -674,16 +681,18 @@ class TopologySpec extends AnyFlatSpec with Matchers {
val expected = val expected =
SeqRes.wrap( SeqRes.wrap(
through(relay), through(relay),
FoldRes("i", valueArray).wrap( FoldRes
SeqRes.wrap( .lastNull("i", valueArray)
through(otherRelay), .wrap(
callRes(1, i) SeqRes.wrap(
), through(otherRelay),
SeqRes.wrap( callRes(1, i)
through(otherRelay), ),
NextRes("i").leaf SeqRes.wrap(
through(otherRelay),
NextRes("i").leaf
)
) )
)
) )
proc.equalsOrShowDiff(expected) should be(true) proc.equalsOrShowDiff(expected) should be(true)
@ -766,22 +775,24 @@ class TopologySpec extends AnyFlatSpec with Matchers {
val expected = SeqRes.wrap( val expected = SeqRes.wrap(
callRes(1, otherPeer), callRes(1, otherPeer),
ParRes.wrap( ParRes.wrap(
FoldRes("i", valueArray, ForModel.Mode.Never.some).wrap( FoldRes
ParRes.wrap( .lastNever("i", valueArray)
SeqRes.wrap( .wrap(
// TODO: should be outside of fold ParRes.wrap(
through(relayV), SeqRes.wrap(
callRes( // TODO: should be outside of fold
2, through(relayV),
LiteralRaw("i", ScalarType.string), callRes(
Some(CallModel.Export("used", StreamType(ScalarType.string))) 2,
LiteralRaw("i", ScalarType.string),
Some(CallModel.Export("used", StreamType(ScalarType.string)))
),
// after call `i` topology should send to `otherPeer2` if it's not fire-and-forget to trigger execution
through(otherPeer2)
), ),
// after call `i` topology should send to `otherPeer2` if it's not fire-and-forget to trigger execution NextRes("i").leaf
through(otherPeer2) )
),
NextRes("i").leaf
) )
)
), ),
callRes(3, otherPeer2, None, VarModel("used", StreamType(ScalarType.string)) :: Nil) callRes(3, otherPeer2, None, VarModel("used", StreamType(ScalarType.string)) :: Nil)
) )
@ -843,21 +854,23 @@ class TopologySpec extends AnyFlatSpec with Matchers {
val expected = SeqRes.wrap( val expected = SeqRes.wrap(
ParRes.wrap( ParRes.wrap(
FoldRes("i", ValueModel.fromRaw(valueArray), ForModel.Mode.Never.some).wrap( FoldRes
ParRes.wrap( .lastNever("i", ValueModel.fromRaw(valueArray))
SeqRes.wrap( .wrap(
through(relay), ParRes.wrap(
callRes( SeqRes.wrap(
1, through(relay),
ValueModel.fromRaw(i), callRes(
Some(CallModel.Export(used.name, used.`type`)) 1,
ValueModel.fromRaw(i),
Some(CallModel.Export(used.name, used.`type`))
),
through(relay),
through(initPeer)
), ),
through(relay), NextRes("i").leaf
through(initPeer) )
),
NextRes("i").leaf
) )
)
) +: ) +:
joinRes :+ joinRes :+
callRes(3, initPeer, None, ValueModel.fromRaw(used) :: Nil) callRes(3, initPeer, None, ValueModel.fromRaw(used) :: Nil)
@ -892,25 +905,27 @@ class TopologySpec extends AnyFlatSpec with Matchers {
val proc = Topology.resolve(init).value val proc = Topology.resolve(init).value
val foldRes = ParRes.wrap( val foldRes = ParRes.wrap(
FoldRes("i", ValueModel.fromRaw(valueArray), ForModel.Mode.Never.some).wrap( FoldRes
ParRes.wrap( .lastNever("i", ValueModel.fromRaw(valueArray))
SeqRes.wrap( .wrap(
through(relay), ParRes.wrap(
XorRes.wrap( SeqRes.wrap(
SeqRes.wrap( through(relay),
callRes( XorRes.wrap(
1, SeqRes.wrap(
ValueModel.fromRaw(i), callRes(
Some(CallModel.Export(used.name, used.`type`)) 1,
), ValueModel.fromRaw(i),
through(relay), Some(CallModel.Export(used.name, used.`type`))
through(initPeer) ),
through(relay),
through(initPeer)
)
) )
) ),
), NextRes("i").leaf
NextRes("i").leaf )
) )
)
) )
val expected = SeqRes.wrap( val expected = SeqRes.wrap(
foldRes +: foldRes +:
@ -1036,9 +1051,11 @@ class TopologySpec extends AnyFlatSpec with Matchers {
CallModel.Export(array.name, array.`type`) CallModel.Export(array.name, array.`type`)
).leaf ).leaf
), ),
FoldRes(iterName, array, ForModel.Mode.Null.some).wrap( FoldRes
NextRes(iterName).leaf .lastNull(iterName, array)
) .wrap(
NextRes(iterName).leaf
)
) )
proc.equalsOrShowDiff(expected) shouldEqual true proc.equalsOrShowDiff(expected) shouldEqual true

View File

@ -21,6 +21,7 @@ import cats.syntax.apply.*
import cats.syntax.flatMap.* import cats.syntax.flatMap.*
import cats.syntax.functor.* import cats.syntax.functor.*
import cats.syntax.option.* import cats.syntax.option.*
import aqua.parser.expr.func.ForExpr.Mode
class ForSem[S[_]](val expr: ForExpr[S]) extends AnyVal { class ForSem[S[_]](val expr: ForExpr[S]) extends AnyVal {
@ -44,7 +45,14 @@ class ForSem[S[_]](val expr: ForExpr[S]) extends AnyVal {
case ForExpr.Mode.TryMode => TryTag case ForExpr.Mode.TryMode => TryTag
} }
val mode = expr.mode.collect { case ForExpr.Mode.ParMode => ForTag.Mode.Wait } /**
* `for ... par` => blocking (`never` as `last` in `fold`)
* `for` and `for ... try` => non blocking (`null` as `last` in `fold`)
*/
val mode = expr.mode.fold(ForTag.Mode.NonBlocking) {
case ForExpr.Mode.ParMode => ForTag.Mode.Blocking
case Mode.TryMode => ForTag.Mode.NonBlocking
}
val forTag = ForTag(expr.item.value, vm, mode).wrap( val forTag = ForTag(expr.item.value, vm, mode).wrap(
innerTag.wrap( innerTag.wrap(

View File

@ -22,7 +22,7 @@ import cats.syntax.functor.*
class ParSeqSem[S[_]](val expr: ParSeqExpr[S]) extends AnyVal { class ParSeqSem[S[_]](val expr: ParSeqExpr[S]) extends AnyVal {
def program[F[_]: Monad](implicit def program[F[_]: Monad](using
V: ValuesAlgebra[S, F], V: ValuesAlgebra[S, F],
N: NamesAlgebra[S, F], N: NamesAlgebra[S, F],
T: TypesAlgebra[S, F], T: TypesAlgebra[S, F],
@ -63,12 +63,18 @@ class ParSeqSem[S[_]](val expr: ParSeqExpr[S]) extends AnyVal {
via = Chain.fromSeq(viaVM), via = Chain.fromSeq(viaVM),
strategy = OnTag.ReturnStrategy.Relay.some strategy = OnTag.ReturnStrategy.Relay.some
) )
tag = ForTag(expr.item.value, vm).wrap( /**
ParTag.wrap( * `parseq` => blocking (`never` as `last` in `fold`)
onTag.wrap(restricted), * So that peer initiating `parseq` would not continue execution past it
NextTag(expr.item.value).leaf */
tag = ForTag
.blocking(expr.item.value, vm)
.wrap(
ParTag.wrap(
onTag.wrap(restricted),
NextTag(expr.item.value).leaf
)
) )
)
} yield tag.toFuncOp } yield tag.toFuncOp
case (None, _, _) => Raw.error("ParSeqSem: could not resolve `peerId`").pure case (None, _, _) => Raw.error("ParSeqSem: could not resolve `peerId`").pure
case (_, None, _) => Raw.error("ParSeqSem: could not resolve `iterable`").pure case (_, None, _) => Raw.error("ParSeqSem: could not resolve `iterable`").pure

View File

@ -581,7 +581,7 @@ class SemanticsSpec extends AnyFlatSpec with Matchers with Inside {
|""".stripMargin |""".stripMargin
insideBody(script) { body => insideBody(script) { body =>
matchSubtree(body) { case (ForTag("p", _, None), forTag) => matchSubtree(body) { case (ForTag("p", _, ForTag.Mode.Blocking), forTag) =>
matchChildren(forTag) { case (ParTag, parTag) => matchChildren(forTag) { case (ParTag, parTag) =>
matchChildren(parTag)( matchChildren(parTag)(
{ case (OnTag(_, _, strat), _) => { case (OnTag(_, _, strat), _) =>